Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753818AbcD2M6p (ORCPT ); Fri, 29 Apr 2016 08:58:45 -0400 Received: from mailout3.hostsharing.net ([176.9.242.54]:51257 "EHLO mailout3.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753797AbcD2M6n (ORCPT ); Fri, 29 Apr 2016 08:58:43 -0400 Date: Fri, 29 Apr 2016 15:01:23 +0200 From: Lukas Wunner To: "Zheng, Lv" Cc: "Rafael J. Wysocki" , "Chen, Yu C" , Lv Zheng , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "Brown, Len" Subject: Re: [PATCH v2 4/6] ACPI / osi: Fix default _OSI(Darwin) support Message-ID: <20160429130123.GA18473@wunner.de> References: <36DF59CE26D8EE47B0655C516E9CE64028748233@shsmsx102.ccr.corp.intel.com> <2223787.tzTyTqLAjo@vostro.rjw.lan> <1AE640813FDE7649BE1B193DEA596E883BB82C18@SHSMSX101.ccr.corp.intel.com> <1AE640813FDE7649BE1B193DEA596E883BB82EF4@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1AE640813FDE7649BE1B193DEA596E883BB82EF4@SHSMSX101.ccr.corp.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 985 Lines: 31 Hi Lv Zheng, On Fri, Apr 29, 2016 at 02:07:53AM +0000, Zheng, Lv wrote: > I just sent UPDATE of PATCH 4/6 and PATCH 6/6 to the mailing list with this > corrected. > I was hoping they could update patchwork content so that the Bugzilla > reporters might use the updated patches for confirmation. > The Message-Id(s) of the 2 patches were kept as same as the old ones. As promised on Bugzilla I've tested v2 of this series (with the "INC" manually fixed up) on a MacBookPro9,1. I only reviewed the patches in a superficial fashion, but one issue I've noticed is that #define pr_fmt(fmt) "ACPI: " fmt is missing in osi.c (patch [6/6]). Without command line arguments, Linux responds yay to _OSI("Darwin") and nothing else and the Thunderbolt controller is powered up. With "acpi_osi=!Darwin", Linux responds nay to everything and the Thunderbolt controller is powered down. So it seems to work as intended. If you want me to test anything else please let me know. Thanks, Lukas