Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753623AbcD2NNF (ORCPT ); Fri, 29 Apr 2016 09:13:05 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:33714 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753364AbcD2NNC (ORCPT ); Fri, 29 Apr 2016 09:13:02 -0400 Date: Fri, 29 Apr 2016 15:13:03 +0200 From: Johan Hovold To: Grigori Goronzy Cc: Johan Hovold , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 07/13] USB: ch341: add debug output for chip version Message-ID: <20160429131303.GK22229@localhost> References: <1460754856-27908-1-git-send-email-greg@chown.ath.cx> <1460754856-27908-8-git-send-email-greg@chown.ath.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460754856-27908-8-git-send-email-greg@chown.ath.cx> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 845 Lines: 27 On Fri, Apr 15, 2016 at 11:14:10PM +0200, Grigori Goronzy wrote: > There are at least two hardware revisions, this may be helpful in > case compatibility issues need to be debugged. > > Signed-off-by: Grigori Goronzy > --- > drivers/usb/serial/ch341.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c > index 2fbec4a..e475677 100644 > --- a/drivers/usb/serial/ch341.c > +++ b/drivers/usb/serial/ch341.c > @@ -209,6 +209,7 @@ static int ch341_configure(struct usb_device *dev, struct ch341_private *priv) > r = ch341_control_in(dev, CH341_VERSION, 0, 0, buffer, size); > if (r < 0) > goto out; > + dev_dbg(&dev->dev, "Chip version: %d\n", buffer[0]); 0x%02x? > > r = ch341_control_out(dev, CH341_SERIAL_INIT, 0, 0); > if (r < 0) Thanks, Johan