Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753819AbcD2Nxv (ORCPT ); Fri, 29 Apr 2016 09:53:51 -0400 Received: from e28smtp06.in.ibm.com ([125.16.236.6]:37127 "EHLO e28smtp06.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753360AbcD2Nxu (ORCPT ); Fri, 29 Apr 2016 09:53:50 -0400 X-IBM-Helo: d28dlp03.in.ibm.com X-IBM-MailFrom: hemant@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Message-ID: <5723675B.5000609@linux.vnet.ibm.com> Date: Fri, 29 Apr 2016 19:23:31 +0530 From: Hemant Kumar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Masami Hiramatsu , Arnaldo Carvalho de Melo CC: linux-kernel@vger.kernel.org, Namhyung Kim , Peter Zijlstra , Ingo Molnar , Ananth N Mavinakayanahalli Subject: Re: [PATCH perf/core v5 00/15] perf-probe --cache and SDT support References: <20160427183701.23446.15293.stgit@devbox> In-Reply-To: <20160427183701.23446.15293.stgit@devbox> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16042913-0021-0000-0000-00000C068F1F Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2947 Lines: 77 Hi Masami, On 04/28/2016 12:07 AM, Masami Hiramatsu wrote: > Hi, > > Here is the 5th version of the patchset for probe-cache and > initial SDT support which are going to be perf-cache finally. > > The previous version is here; https://lkml.org/lkml/2016/4/26/179 > > This version fixes a build bug on "make build-test", removed > accepted patches, and fold buildid-cache style change and backward > compatibility patches. > IOW, just a cleanup version :) > > TODOs are here, but I think it should involve kernel-side change > to complete. > - (perf record) Support SDT event recording directly > - (perf record) Support @FILE/@BUILDID suffix to record specific SDTs. > - (perf record) Try to unregister SDT events after record. I just sent a patch enabling direct recording on SDT events implementing 1st and 3rd TODOs of the above list. Its based on your patches. Let me know your thoughts on the same. -- Thanks, Hemant Kumar > - (ftrace) Support multiple SDTs on single event. > > Thank you, > > --- > > Hemant Kumar (1): > perf/sdt: ELF support for SDT > > Masami Hiramatsu (14): > perf probe: Use strbuf for making strings > perf-buildid-cache: Use path/to/bin/buildid/elf instead of path/to/bin/buildid > perf-buildid-cache: Use lsdir for looking up buildid caches > perf probe: Add --cache option to cache the probe definitions > perf probe: Use cache entry if possible > perf probe: Show all cached probes > perf probe: Remove caches when --cache is given > perf probe: Add group name support > perf buildid-cache: Scan and import user SDT events to probe cache > perf probe: Accept %sdt and %cached event name > perf-list: Show SDT and pre-cached events > perf-list: Skip SDTs placed in invalid binaries > perf probe: Allow wildcard for cached events > perf probe: Support @BUILDID or @FILE suffix for SDT events > > > tools/perf/Documentation/perf-probe.txt | 24 + > tools/perf/builtin-list.c | 4 > tools/perf/builtin-probe.c | 30 + > tools/perf/util/build-id.c | 278 ++++++++++--- > tools/perf/util/build-id.h | 6 > tools/perf/util/dso.h | 5 > tools/perf/util/parse-events.c | 83 ++++ > tools/perf/util/parse-events.h | 2 > tools/perf/util/probe-event.c | 684 ++++++++++++++++++++++--------- > tools/perf/util/probe-event.h | 9 > tools/perf/util/probe-file.c | 492 ++++++++++++++++++++++ > tools/perf/util/probe-file.h | 41 ++ > tools/perf/util/probe-finder.c | 14 - > tools/perf/util/symbol-elf.c | 252 +++++++++++ > tools/perf/util/symbol.c | 15 - > tools/perf/util/symbol.h | 22 + > 16 files changed, 1689 insertions(+), 272 deletions(-) > > -- > Masami Hiramatsu >