Date: Fri, 29 Apr 2016 11:11:49 -0300
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
To: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 02/13] staging/android: drop sync_file_install() and
 sync_file_put()
Message-ID: <20160429141149.GD2524@joana>
References: <00da01d1a1ed$f8d8e4a0$ea8aade0$@alibaba-inc.com>
 <00dc01d1a1ef$2692b6e0$73b824a0$@alibaba-inc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <00dc01d1a1ef$2692b6e0$73b824a0$@alibaba-inc.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 788
Lines: 19

2016-04-29 Hillf Danton <hillf.zj@alibaba-inc.com>:

> > 
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > 
> > These two functions are just wrappers for one line functions, they
> > call fd_install() and fput() respectively, so just get rid of them
> > and use fd_install() and fput() directly for more simplicity.
> > 
> Given sync_file is not file, I don't see that simplicity is worth of
> the change of 20+ lines.
> Can you please specify the disadvantages of the wrappers?

Our idea here was to simplify as much as possible this API, also we do
not want to hide sync_file internals from its users. This is staging
and we are re-thinking the API (and userspace ABI too) before moving it
out if staging. I can add some more information to the commit message.

	Gustavo