Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754012AbcD2PiX (ORCPT ); Fri, 29 Apr 2016 11:38:23 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:33903 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753974AbcD2PiU (ORCPT ); Fri, 29 Apr 2016 11:38:20 -0400 Subject: Re: [PATCH v2 03/11] serial: sh-sci: Always set TIOCM_CTS in .get_mctrl() callback To: Geert Uytterhoeven , Greg Kroah-Hartman References: <1461934714-18681-1-git-send-email-geert+renesas@glider.be> <1461934714-18681-4-git-send-email-geert+renesas@glider.be> Cc: Jiri Slaby , Magnus Damm , Laurent Pinchart , Yoshinori Sato , linux-serial@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org From: Peter Hurley Message-ID: <57237FE1.8030200@hurleysoftware.com> Date: Fri, 29 Apr 2016 08:38:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1461934714-18681-4-git-send-email-geert+renesas@glider.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 561 Lines: 14 On 04/29/2016 05:58 AM, Geert Uytterhoeven wrote: > Documentation/serial/driver clearly states: > > If the port does not support CTS, DCD or DSR, the driver should > indicate that the signal is permanently active. > > Hence always set TIOCM_CTS, as we currently don't look at the CTS > hardware line state at all. > > FWIW, this fixes the transmit path when hardware-assisted flow control > is enabled, and userspace enables CRTSCTS. > The receive path is still broken, as RTS is never asserted. Reviewed-by: Peter Hurley