Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753974AbcD2QCg (ORCPT ); Fri, 29 Apr 2016 12:02:36 -0400 Received: from mail-bl2nam02on0052.outbound.protection.outlook.com ([104.47.38.52]:14496 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753391AbcD2QCf (ORCPT ); Fri, 29 Apr 2016 12:02:35 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=xilinx.com; Date: Fri, 29 Apr 2016 09:01:58 -0700 From: =?utf-8?B?U8O2cmVu?= Brinkmann To: Shawn Lin CC: Adrian Hunter , Ulf Hansson , Jaehoon Chung , "Michal Simek" , Rob Herring , , , Doug Anderson , Heiko Stuebner , , Subject: Re: [PATCH v2 6/6] mmc: sdhci-of-arasan: overwrite enhanced strobe callback Message-ID: <20160429160158.GZ3766@xsjsorenbubuntu> References: <1461897751-28810-1-git-send-email-shawn.lin@rock-chips.com> <1461898114-29067-1-git-send-email-shawn.lin@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1461898114-29067-1-git-send-email-shawn.lin@rock-chips.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22290.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(189002)(377424004)(24454002)(199003)(9686002)(110136002)(76506005)(2906002)(4001350100001)(57986006)(47776003)(76176999)(54356999)(63266004)(575784001)(86362001)(2950100001)(50466002)(2870700001)(81166005)(77096005)(19580405001)(9786002)(92566002)(36386004)(19580395003)(4326007)(6806005)(1076002)(50986999)(1220700001)(1096002)(85202003)(23676002)(586003)(5008740100001)(106466001)(87936001)(230783001)(85182001)(189998001)(33716001)(33656002)(83506001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1NAM02HT211;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;MLV:sfv;MX:1;A:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 47773c95-cdda-4d1f-75b8-08d37047ac5b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:CY1NAM02HT211; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(9101521072)(601004)(2401047)(13015025)(8121501046)(13018025)(13024025)(5005006)(13017025)(13023025)(3002001)(10201501046)(6055026);SRVR:CY1NAM02HT211;BCL:0;PCL:0;RULEID:;SRVR:CY1NAM02HT211; X-Forefront-PRVS: 0927AA37C7 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2016 16:02:31.9941 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1NAM02HT211 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1081 Lines: 31 On Fri, 2016-04-29 at 10:48:34 +0800, Shawn Lin wrote: > Currently sdhci-arasan 5.1 can support enhanced strobe function, > and we now limit it just for "arasan,sdhci-5.1". Add > mmc-hs400-enhanced-strobe in DT to enable the function if we'r sure > our controller can support it. > > Signed-off-by: Shawn Lin > --- > > Changes in v2: None > > drivers/mmc/host/sdhci-of-arasan.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c > index 20b859e..a0e4536 100644 > --- a/drivers/mmc/host/sdhci-of-arasan.c > +++ b/drivers/mmc/host/sdhci-of-arasan.c > @@ -25,7 +25,9 @@ > #include "sdhci-pltfm.h" > > #define SDHCI_ARASAN_CLK_CTRL_OFFSET 0x2c > +#define SDHCI_ARASAN_VENDOR_REGISTER 0x78 Just as a note: This register doesn't seem to exist in the IP version Zynq is using. So, as long as we exclude that version from accessing it, things should be fine (IIUC, that is the case). Acked-by: Sören Brinkmann Sören