Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752806AbcD2RIa (ORCPT ); Fri, 29 Apr 2016 13:08:30 -0400 Received: from mail-db3on0054.outbound.protection.outlook.com ([157.55.234.54]:44032 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752678AbcD2RI3 convert rfc822-to-8bit (ORCPT ); Fri, 29 Apr 2016 13:08:29 -0400 X-Greylist: delayed 8304 seconds by postgrey-1.27 at vger.kernel.org; Fri, 29 Apr 2016 13:08:28 EDT From: Han Xu To: Boris Brezillon CC: "richard@nod.at" , "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] mtd: nand: gpmi: get correct free oob space Thread-Topic: [PATCH] mtd: nand: gpmi: get correct free oob space Thread-Index: AQHRlQdWABtVKJiyPEOffXXGKjxePp+G74KAgBnJXACAAGVWLQ== Date: Fri, 29 Apr 2016 14:35:10 +0000 Message-ID: References: <1460498793-19431-1-git-send-email-han.xu@nxp.com> <20160413004351.40064fcd@bbrezillon>,<20160429103102.10ca50f7@bbrezillon> In-Reply-To: <20160429103102.10ca50f7@bbrezillon> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nod.at; dkim=none (message not signed) header.d=none;nod.at; dmarc=none action=none header.from=nxp.com; x-originating-ip: [132.245.61.53] x-ms-office365-filtering-correlation-id: 805f7efa-d20f-47e2-f3f5-08d3703b77e3 x-microsoft-exchange-diagnostics: 1;DB5PR0401MB1847;5:7CPb+ztoyKHzCdWIBjuUPk2lmztWzNOSBcW35qxD0UilMQLRZMszli+Ov7g6J6eTuHUCn8zbfpMo6MkvCzh2NsAGye/57BX/8qfAG79KREbftq+BAGDQPReSyghTm1QTEMPK9L9jOX+BWd5nAfkpsQ==;24:dtGVXG/sUSI05fWdx/hSocN771OTynsqIDs4SY+p2PGBr2hXPzsDlxf1iE00yV152zuZQkP764gdpLzWzCzRk1aSKZsjlwMSssT+YxVxkys=;7:eIUj9ftpunWtVkP6j/zdtGUxeBPlNQ/EozZnfYyujLNrs7jK6fV888cJUe3z1Q4+OHLBpro3tP8pCLP992ZhY1WojpaRZFOlXF0Q6uO1uumuRKbBEJjBsf+C+m/RkbLO2MNrg2fAHwPYxCB4D7/QzOVwrjQpBMWYmO78sh6f/bRBRalhpatvYFt0tndXBVVY x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR0401MB1847; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(9101521072)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:DB5PR0401MB1847;BCL:0;PCL:0;RULEID:;SRVR:DB5PR0401MB1847; x-forefront-prvs: 0927AA37C7 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(24454002)(377454003)(50986999)(76176999)(5008740100001)(54356999)(10400500002)(33656002)(9686002)(3280700002)(3900700001)(1096002)(2906002)(3660700001)(66066001)(189998001)(1220700001)(19580395003)(19580405001)(74316001)(110136002)(86362001)(11100500001)(15975445007)(6116002)(81166005)(586003)(5004730100002)(87936001)(2900100001)(5002640100001)(3846002)(4326007)(122556002)(2950100001)(92566002)(5003600100002)(77096005)(102836003)(76576001)(106116001)(586874002)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR0401MB1847;H:DB5PR0401MB1845.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2016 14:35:10.4149 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0401MB1847 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1158 Lines: 41 ________________________________________ From: Boris Brezillon Sent: Friday, April 29, 2016 2:31 AM To: Han Xu Cc: richard@nod.at; dwmw2@infradead.org; computersforpeace@gmail.com; linux-mtd@lists.infradead.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: nand: gpmi: get correct free oob space Hi Han, On Wed, 13 Apr 2016 00:43:51 +0200 Boris Brezillon wrote: > Hi Han, > > On Tue, 12 Apr 2016 17:06:33 -0500 > Han Xu wrote: > > > change the way to calculate pagesize to get correct free oob space for > > legacy_set_geometry function. > > Are you sure it's safe to expose free OOB bytes in this case? Do you > know why it wasn't done before? You did not answer this question. Do you want me to drop this patch. If that's not the case, can you confirm it does not break platforms that didn't have those free OOB bytes exposed before this change. I think it's safe to expose the free OOB and also tested on my side, no issue found. Thanks, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com