Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752490AbcD2Syz (ORCPT ); Fri, 29 Apr 2016 14:54:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57404 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbcD2Syy (ORCPT ); Fri, 29 Apr 2016 14:54:54 -0400 Date: Fri, 29 Apr 2016 14:54:52 -0400 From: Mike Snitzer To: Michal Hocko Cc: Andrew Morton , Michal Hocko , LKML , linux-mm@kvack.org, dm-devel@redhat.com, Mikulas Patocka , Shaohua Li Subject: Re: [PATCH 17/20] dm: get rid of superfluous gfp flags Message-ID: <20160429185451.GA21865@redhat.com> References: <1461849846-27209-1-git-send-email-mhocko@kernel.org> <1461849846-27209-18-git-send-email-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461849846-27209-18-git-send-email-mhocko@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 963 Lines: 21 On Thu, Apr 28 2016 at 9:24am -0400, Michal Hocko wrote: > From: Michal Hocko > > copy_params seems to be little bit confused about which allocation flags > to use. It enforces GFP_NOIO even though it uses > memalloc_noio_{save,restore} which enforces GFP_NOIO at the page > allocator level automatically (via memalloc_noio_flags). It also > uses __GFP_REPEAT for the __vmalloc request which doesn't make much > sense either because vmalloc doesn't rely on costly high order > allocations. Let's just drop the __GFP_REPEAT and leave the further > cleanup to later changes. > > Cc: Shaohua Li > Cc: Mikulas Patocka > Cc: dm-devel@redhat.com > Signed-off-by: Michal Hocko I've taken this patch for 4.7 but editted the header, see: https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.7&id=0222c76e96163355620224625c1cd80991086dc7