Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752423AbcD2TNk (ORCPT ); Fri, 29 Apr 2016 15:13:40 -0400 Received: from mail-io0-f175.google.com ([209.85.223.175]:34742 "EHLO mail-io0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752352AbcD2TNi (ORCPT ); Fri, 29 Apr 2016 15:13:38 -0400 From: Sathya Prakash Veerichetty References: <1460761950-8006-1-git-send-email-khoroshilov@ispras.ru> In-Reply-To: MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQJUgJRajkvk63fnxFAU9/amdEDtWgLHhGfTnoVYAsA= Date: Fri, 29 Apr 2016 13:13:36 -0600 Message-ID: Subject: RE: [PATCH] mptsas: fix checks for dma mapping errors To: "Martin K. Petersen" , Alexey Khoroshilov Cc: Sreekanth Reddy , Chaitra Basappa , Suganath Prabu Subramani , PDL-MPT-FUSIONLINUX , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 975 Lines: 26 Please consider this patch as Ack-by: Sathya Prakash Veerichetty PS: We don't have test environment to test this patch as this is for an old controller. So ACKing based on code review and similar mpt3sas driver code. -----Original Message----- From: Martin K. Petersen [mailto:martin.petersen@oracle.com] Sent: Wednesday, April 27, 2016 7:18 PM To: Alexey Khoroshilov Cc: Sreekanth Reddy; Sathya Prakash; Chaitra P B; Suganath Prabu Subramani; MPT-FusionLinux.pdl@broadcom.com; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; ldv-project@linuxtesting.org Subject: Re: [PATCH] mptsas: fix checks for dma mapping errors >>>>> "Alexey" == Alexey Khoroshilov writes: Alexey> mptsas_smp_handler() checks for dma mapping errors by comparison Alexey> returned address with zero, while pci_dma_mapping_error() should Alexey> be used. Broadcom folks, please review! -- Martin K. Petersen Oracle Linux Engineering