Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752944AbcD2U2e (ORCPT ); Fri, 29 Apr 2016 16:28:34 -0400 Received: from mga11.intel.com ([192.55.52.93]:61793 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752374AbcD2U2d (ORCPT ); Fri, 29 Apr 2016 16:28:33 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,553,1455004800"; d="scan'208";a="795295174" Subject: Re: [PATCH v4 09/10] x86/xsaves: Fix xstate_offsets, xstate_sizes for legacy components To: Yu-cheng Yu , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org References: <4403c9c97c44e214933964d2cd37a884ffd6be99.1457038929.git.yu-cheng.yu@intel.com> Cc: Andy Lutomirski , Borislav Petkov , Sai Praneeth Prakhya , "Ravi V. Shankar" , Fenghua Yu From: Dave Hansen Message-ID: <5723C3EF.7000102@linux.intel.com> Date: Fri, 29 Apr 2016 13:28:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <4403c9c97c44e214933964d2cd37a884ffd6be99.1457038929.git.yu-cheng.yu@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 343 Lines: 10 On 03/04/2016 10:12 AM, Yu-cheng Yu wrote: > The arrays xstate_offsets[] and xstate_sizes[] record XSAVE area > offsets and sizes. Values for legacy components i387 and XMMs were > not initialized. Fix it. Is this just a completeness thing or does it actually break something? In any case: Reviewed-by: Dave Hansen