Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753145AbcD2Usc (ORCPT ); Fri, 29 Apr 2016 16:48:32 -0400 Received: from g1t5425.austin.hp.com ([15.216.225.55]:40090 "EHLO g1t5425.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753018AbcD2Usa (ORCPT ); Fri, 29 Apr 2016 16:48:30 -0400 From: Toshi Kani To: dan.j.williams@intel.com, david@fromorbit.com, jack@suse.cz Cc: tytso@mit.edu, adilger.kernel@dilger.ca, ross.zwisler@linux.intel.com, toshi.kani@hpe.com, linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] xfs: Add alignment check for DAX mount Date: Fri, 29 Apr 2016 14:39:35 -0600 Message-Id: <1461962375-3720-4-git-send-email-toshi.kani@hpe.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1461962375-3720-1-git-send-email-toshi.kani@hpe.com> References: <1461962375-3720-1-git-send-email-toshi.kani@hpe.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1155 Lines: 31 When a partition is not aligned by 4KB, mount -o dax succeeds, but any read/write access to the filesystem fails, except for metadata update. Add alignment check to xfs_fs_fill_super() when -o dax is specified. Signed-off-by: Toshi Kani Cc: Dave Chinner (supporter:XFS FILESYSTEM) Cc: Dan Williams Cc: Ross Zwisler --- fs/xfs/xfs_super.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index 187e14b..a17aebc 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -1563,6 +1563,11 @@ xfs_fs_fill_super( xfs_alert(mp, "Filesystem block size invalid for DAX Turning DAX off."); mp->m_flags &= ~XFS_MOUNT_DAX; + } else if (sb->s_bdev->bd_part->start_sect % (PAGE_SIZE / 512) + || sb->s_bdev->bd_part->nr_sects % (PAGE_SIZE / 512)) { + xfs_alert(mp, + "Partition alignment invalid for DAX Turning DAX off."); + mp->m_flags &= ~XFS_MOUNT_DAX; } else if (!sb->s_bdev->bd_disk->fops->direct_access) { xfs_alert(mp, "Block device does not support DAX Turning DAX off.");