Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752384AbcD2WUD (ORCPT ); Fri, 29 Apr 2016 18:20:03 -0400 Received: from mga14.intel.com ([192.55.52.115]:8045 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751204AbcD2WUB (ORCPT ); Fri, 29 Apr 2016 18:20:01 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,553,1455004800"; d="scan'208";a="969471072" Date: Fri, 29 Apr 2016 15:15:52 -0700 From: Yu-cheng Yu To: Dave Hansen Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, Andy Lutomirski , Borislav Petkov , Sai Praneeth Prakhya , "Ravi V. Shankar" , Fenghua Yu Subject: Re: [PATCH v4 09/10] x86/xsaves: Fix xstate_offsets, xstate_sizes for legacy components Message-ID: <20160429221552.GA15703@test-lenovo> References: <4403c9c97c44e214933964d2cd37a884ffd6be99.1457038929.git.yu-cheng.yu@intel.com> <5723C3EF.7000102@linux.intel.com> <20160429220729.GA15679@test-lenovo> <5723DC8D.8090605@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5723DC8D.8090605@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 662 Lines: 17 On Fri, Apr 29, 2016 at 03:13:33PM -0700, Dave Hansen wrote: > On 04/29/2016 03:07 PM, Yu-cheng Yu wrote: > > On Fri, Apr 29, 2016 at 01:28:31PM -0700, Dave Hansen wrote: > >> On 03/04/2016 10:12 AM, Yu-cheng Yu wrote: > >>> The arrays xstate_offsets[] and xstate_sizes[] record XSAVE area > >>> offsets and sizes. Values for legacy components i387 and XMMs were > >>> not initialized. Fix it. > >> > >> Is this just a completeness thing or does it actually break something? > > > > PTRACE format conversion needs them. > > If you respin these, can you please note that in the changelog and/or > comments? Do you mean when it is rebased? I will do that.