Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752690AbcD2XRA (ORCPT ); Fri, 29 Apr 2016 19:17:00 -0400 Received: from mga09.intel.com ([134.134.136.24]:59021 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752231AbcD2XQ7 (ORCPT ); Fri, 29 Apr 2016 19:16:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,553,1455004800"; d="scan'208";a="795395407" Date: Fri, 29 Apr 2016 16:12:52 -0700 From: Yu-cheng Yu To: Dave Hansen Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, Andy Lutomirski , Borislav Petkov , Sai Praneeth Prakhya , "Ravi V. Shankar" , Fenghua Yu Subject: Re: [PATCH v4 10/10] x86/xsaves: Re-enable XSAVES Message-ID: <20160429231252.GA15765@test-lenovo> References: <5723C4CF.3050209@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5723C4CF.3050209@linux.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 731 Lines: 14 On Fri, Apr 29, 2016 at 01:32:15PM -0700, Dave Hansen wrote: > The reason I haven't acked this patch is that I want to be _sure_ that > we've audited all of the call paths that access the XSAVE buffer to > ensure that they can all either handle the XSAVES format *or* don't care > for whatever reason. > > Could you share the steps that you've taken to assure yourself that all > of the call paths are handled and we don't have more bugs? > We tested for signal, ptrace, context switch, avx, and mpx. We also run these tests with your audit patch to detect any format mis-match. That said, I cannot be sure there are no more bugs. As you said, we want to get this feature tested in the field and find potential issues early.