Date: Sat, 30 Apr 2016 18:12:20 +0800
From: Minfei Huang <mnghuan@gmail.com>
To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, luto@kernel.org,
        pbonzini@redhat.com, bp@suse.de, mtosatti@redhat.com
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Cleanup __pvclock_read_cycles to remove useless variables
Message-ID: <20160430101220.GA27909@huangminfeis-MacBook-Pro.local>
References: <1461567194-2007-1-git-send-email-mnghuan@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1461567194-2007-1-git-send-email-mnghuan@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1196
Lines: 49

ping.

Any comment is appreciate.

Thanks
Minfei

On 04/25/16 at 02:53P, Minfei Huang wrote:
> The value of cycles and flags can be assigned directly without
> intermediate variables.
> 
> Remove the useless variables.
> 
> Signed-off-by: Minfei Huang <mnghuan@gmail.com>
> ---
>  arch/x86/include/asm/pvclock.h | 15 ++++-----------
>  1 file changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/x86/include/asm/pvclock.h b/arch/x86/include/asm/pvclock.h
> index fdcc040..fb95dac 100644
> --- a/arch/x86/include/asm/pvclock.h
> +++ b/arch/x86/include/asm/pvclock.h
> @@ -80,19 +80,12 @@ static __always_inline
>  unsigned __pvclock_read_cycles(const struct pvclock_vcpu_time_info *src,
>  			       cycle_t *cycles, u8 *flags)
>  {
> -	unsigned version;
> -	cycle_t ret, offset;
> -	u8 ret_flags;
> -
> -	version = src->version;
> +	cycle_t offset;
>  
>  	offset = pvclock_get_nsec_offset(src);
> -	ret = src->system_time + offset;
> -	ret_flags = src->flags;
> -
> -	*cycles = ret;
> -	*flags = ret_flags;
> -	return version;
> +	*cycles = src->system_time + offset;
> +	*flags = src->flags;
> +	return src->version;
>  }
>  
>  struct pvclock_vsyscall_time_info {
> -- 
> 2.6.3
>