Date: Sat, 30 Apr 2016 18:13:03 +0800
From: Minfei Huang <mnghuan@gmail.com>
To: keith.busch@intel.com, axboe@fb.com
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Use MICRO UINT_MAX instead of actual value
Message-ID: <20160430101303.GB27909@huangminfeis-MacBook-Pro.local>
References: <1461554009-1695-1-git-send-email-mnghuan@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1461554009-1695-1-git-send-email-mnghuan@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 950
Lines: 32

Ping.

Any comment is appreciate.

Thanks
Minfei

On 04/25/16 at 11:13P, Minfei Huang wrote:
> It's more elegant to use MICRO UINT_MAX to represent the max value of
> type unsigned int. So replace the actual value by using this MICRO.
> 
> Signed-off-by: Minfei Huang <mnghuan@gmail.com>
> ---
>  drivers/nvme/host/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 643f457..2c0bb13 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -597,7 +597,7 @@ static void nvme_config_discard(struct nvme_ns *ns)
>  
>  	ns->queue->limits.discard_alignment = logical_block_size;
>  	ns->queue->limits.discard_granularity = logical_block_size;
> -	blk_queue_max_discard_sectors(ns->queue, 0xffffffff);
> +	blk_queue_max_discard_sectors(ns->queue, UINT_MAX);
>  	queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, ns->queue);
>  }
>  
> -- 
> 2.6.3
>