Date: Sat, 30 Apr 2016 15:24:21 +0200
From: Borislav Petkov <bp@suse.de>
To: Minfei Huang <mnghuan@gmail.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, luto@kernel.org,
        pbonzini@redhat.com, mtosatti@redhat.com, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Cleanup __pvclock_read_cycles to remove useless variables
Message-ID: <20160430132420.GA4084@pd.tnic>
References: <1461567194-2007-1-git-send-email-mnghuan@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1461567194-2007-1-git-send-email-mnghuan@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1153
Lines: 38

On Mon, Apr 25, 2016 at 02:53:14PM +0800, Minfei Huang wrote:
> The value of cycles and flags can be assigned directly without
> intermediate variables.
> 
> Remove the useless variables.
> 
> Signed-off-by: Minfei Huang <mnghuan@gmail.com>
> ---
>  arch/x86/include/asm/pvclock.h | 15 ++++-----------
>  1 file changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/x86/include/asm/pvclock.h b/arch/x86/include/asm/pvclock.h
> index fdcc040..fb95dac 100644
> --- a/arch/x86/include/asm/pvclock.h
> +++ b/arch/x86/include/asm/pvclock.h
> @@ -80,19 +80,12 @@ static __always_inline
>  unsigned __pvclock_read_cycles(const struct pvclock_vcpu_time_info *src,
>  			       cycle_t *cycles, u8 *flags)
>  {
> -	unsigned version;
> -	cycle_t ret, offset;
> -	u8 ret_flags;
> -
> -	version = src->version;
> +	cycle_t offset;
>  
>  	offset = pvclock_get_nsec_offset(src);

You could go a step further and get rid of that
pvclock_get_nsec_offset() simple wrapper too and move its meat into
__pvclock_read_cycles()...

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--