Date: Sat, 30 Apr 2016 17:14:41 +0100
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Eli Billauer <eli.billauer@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char: xillybus: use devm_add_action_or_reset
Message-ID: <20160430161441.GA24054@sudip-laptop>
References: <1461617489-32569-1-git-send-email-sudipm.mukherjee@gmail.com>
 <571F418C.1090005@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <571F418C.1090005@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 525
Lines: 20

On Tue, Apr 26, 2016 at 01:23:08PM +0300, Eli Billauer wrote:
> Thanks,
> 
> I like the direction, however both xilly_map_single_* functions turn
> out ending with
> 
>     if (rc)
>         return rc;
> 
>     return 0;
> 
> Which is equivalent to just "return rc". Or maybe return the value
> of the devm_add_action_or_reset() call directly, and remove the "rc"
> variable? I don't know which one is better coding style.

ofcourse, it was very silly of me not to notice that.
v2 sent for your consideration.

regards
sudip