Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752406AbcD3RAb (ORCPT ); Sat, 30 Apr 2016 13:00:31 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:37348 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751225AbcD3RAa (ORCPT ); Sat, 30 Apr 2016 13:00:30 -0400 Date: Sat, 30 Apr 2016 18:00:25 +0100 From: Sudip Mukherjee To: Jarkko Sakkinen Cc: Peter Huewe , Marcel Selhorst , Jason Gunthorpe , linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net Subject: Re: [PATCH] tpm: use devm_add_action_or_reset Message-ID: <20160430170025.GB25043@sudip-laptop> References: <1461617198-32351-1-git-send-email-sudipm.mukherjee@gmail.com> <20160426083014.GA29628@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160426083014.GA29628@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 595 Lines: 14 On Tue, Apr 26, 2016 at 11:30:14AM +0300, Jarkko Sakkinen wrote: > On Mon, Apr 25, 2016 at 09:46:38PM +0100, Sudip Mukherjee wrote: > > If devm_add_action() fails we are explicitly calling the cleanup function > > in the error path. Lets use the helper function devm_add_action_or_reset() > > and return directly as we know the cleanup has been done by the helper. > > Have you verified that this compiles against my tree? This was done against linux-next. But now I have just rebased against the charmisc tree and sent v2. Also added the Reviewed-by tag to it. (hope thats ok) regards sudip