Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752446AbcD3T7J (ORCPT ); Sat, 30 Apr 2016 15:59:09 -0400 Received: from mail.windriver.com ([147.11.1.11]:47210 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752022AbcD3T7I (ORCPT ); Sat, 30 Apr 2016 15:59:08 -0400 Date: Sat, 30 Apr 2016 15:58:53 -0400 From: Paul Gortmaker To: Christoph Hellwig CC: "Martin K. Petersen" , , Ming Lin , Sagi Grimberg Subject: Re: [PATCH v2] lib: make sg_pool tristate instead of bool Message-ID: <20160430195852.GD16346@windriver.com> References: <1461465895-676-1-git-send-email-paul.gortmaker@windriver.com> <20160428065151.GA17312@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160428065151.GA17312@lst.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 570 Lines: 16 [Re: [PATCH v2] lib: make sg_pool tristate instead of bool] On 28/04/2016 (Thu 08:51) Christoph Hellwig wrote: > On Wed, Apr 27, 2016 at 07:54:19PM -0400, Martin K. Petersen wrote: > > Somebody please review... > > The patch is useless, we should just ignore it. I'll be the 1st to admit the patch isn't rocket science, but I'm missing why it warrants a blanket "ignore" status. If we have dead code or a disconnect between Kconfig and source, to me that seems worth fixing. Not looking to start a debate; just hoping to understand what I missed. Thanks, Paul. --