Date: Sat, 30 Apr 2016 21:01:24 +0100
From: Matt Fleming <matt@codeblueprint.co.uk>
To: "Compostella, Jeremy" <jeremy.compostella@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>, stefan.stanacar@intel.com,
        peterz@infradead.org, linux-kernel@vger.kernel.org, tglx@linutronix.de,
        hpa@zytor.com, bp@alien8.de, ard.biesheuvel@linaro.org,
        linux-tip-commits@vger.kernel.org
Subject: Re: [tip:efi/core] efibc: Add EFI Bootloader Control module
Message-ID: <20160430200124.GJ2839@codeblueprint.co.uk>
References: <1461614832-17633-26-git-send-email-matt@codeblueprint.co.uk>
 <tip-06f7d4a1618dbb086e738c93cd1ef416ab01027d@git.kernel.org>
 <20160429095356.GA29957@gmail.com>
 <20160429103011.GE2839@codeblueprint.co.uk>
 <87lh3wejfi.fsf@jcompost-MOBL1.tl.intel.com>
 <20160429121635.GF2839@codeblueprint.co.uk>
 <87h9eked24.fsf@jcompost-MOBL1.tl.intel.com>
 <20160429194615.GA22691@gmail.com>
 <874majebs3.fsf@jcompost-MOBL1.tl.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <874majebs3.fsf@jcompost-MOBL1.tl.intel.com>
User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 772
Lines: 21

On Sat, 30 Apr, at 10:33:32AM, Jeremy Compostella wrote:
> Ingo Molnar <mingo@kernel.org> writes:
> >
> > Hm, can reboot notifiers do non-atomic allocations?
> The reboot notifier chain is a blocking notifier chain. AFAIK, it
> allows non-atomic allocation, right ?
 
I would assume so, yes.

> > Why is efivar_entry so huge?
> efivar_entry structure include two "big" arrays of 1024 bytes each for
> the EFI variable name and data.

Yeah. This is partially historical in that the EFI variable code has
always had these arrays.

But it's also that if you're dealing with EFI variables you always
want someplace to cache the data and name, so no one has ever proposed
to split out the data/name from struct efivar_entry.

We've never put them on the stack before either ;)