Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752688AbcDXMrV (ORCPT ); Sun, 24 Apr 2016 08:47:21 -0400 Received: from mprc.pku.edu.cn ([162.105.203.9]:45174 "EHLO mprc.pku.edu.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752618AbcDXMrU (ORCPT ); Sun, 24 Apr 2016 08:47:20 -0400 Message-ID: <61901.222.29.22.96.1461501883.squirrel@mprc.pku.edu.cn> In-Reply-To: <571C0EA5.3090104@roeck-us.net> References: <1458559253-422-1-git-send-email-linux@roeck-us.net> <571C0EA5.3090104@roeck-us.net> Date: Sun, 24 Apr 2016 20:44:43 +0800 (CST) Subject: Re: [PATCH] unicore32: mm: Add missing parameter to arch_vma_access_permitted From: "Xuetao Guan" To: "Guenter Roeck" Cc: "Guan Xuetao" , linux-kernel@vger.kernel.org, "Dave Hansen" , "Thomas Gleixner" , "Ingo Molnar" Reply-To: gxt@mprc.pku.edu.cn User-Agent: SquirrelMail/1.4.8-4.0.1.el5 MIME-Version: 1.0 Content-Type: text/plain;charset=gb2312 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1614 Lines: 48 > ping ... still not upstream. I'm sorry. I'll do it in next week. Xuetao > > On 03/21/2016 04:20 AM, Guenter Roeck wrote: >> unicore32 fails to compile with the following errors. >> >> mm/memory.c: In function ‘__handle_mm_fault??�: >> mm/memory.c:3381: error: >> too many arguments to function ‘arch_vma_access_permitted??� >> mm/gup.c: In function ‘check_vma_flags??�: >> mm/gup.c:456: error: >> too many arguments to function ‘arch_vma_access_permitted??� >> mm/gup.c: In function ‘vma_permits_fault??�: >> mm/gup.c:640: error: >> too many arguments to function ‘arch_vma_access_permitted??� >> >> Fixes: d61172b4b695b ("mm/core, x86/mm/pkeys: Differentiate instruction >> fetches") >> Cc: Dave Hansen >> Cc: Thomas Gleixner >> Cc: Ingo Molnar >> Signed-off-by: Guenter Roeck >> --- >> arch/unicore32/include/asm/mmu_context.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/unicore32/include/asm/mmu_context.h >> b/arch/unicore32/include/asm/mmu_context.h >> index e35632ef23c7..62dfc644c908 100644 >> --- a/arch/unicore32/include/asm/mmu_context.h >> +++ b/arch/unicore32/include/asm/mmu_context.h >> @@ -98,7 +98,7 @@ static inline void arch_bprm_mm_init(struct mm_struct >> *mm, >> } >> >> static inline bool arch_vma_access_permitted(struct vm_area_struct >> *vma, >> - bool write, bool foreign) >> + bool write, bool execute, bool foreign) >> { >> /* by default, allow everything */ >> return true; >> >