Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751388AbcJAQtn (ORCPT ); Sat, 1 Oct 2016 12:49:43 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:56498 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750997AbcJAQtm (ORCPT ); Sat, 1 Oct 2016 12:49:42 -0400 Date: Sat, 1 Oct 2016 10:49:32 -0600 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Peter Huewe , Nayna Jain , Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH 2/2] tpm: replace dynamically allocated bios_dir with a static array Message-ID: <20161001164932.GA13462@obsidianresearch.com> References: <1475325678-16573-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1475325678-16573-3-git-send-email-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475325678-16573-3-git-send-email-jarkko.sakkinen@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 533 Lines: 13 On Sat, Oct 01, 2016 at 03:41:17PM +0300, Jarkko Sakkinen wrote: > - bin_file = > + chip->bios_dir[cnt] = > securityfs_create_file("binary_bios_measurements", > - S_IRUSR | S_IRGRP, tpm_dir, > + S_IRUSR | S_IRGRP, chip->bios_dir[cnt], That is certainly not right, Nayna's version was correct, the function argument is the directory to create under and bios_dir[0] is setup as the directory for tpm. This is also why removal is done in reverse order, files are removed then the directory that contains them. Jason