Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751949AbcJBKY6 (ORCPT ); Sun, 2 Oct 2016 06:24:58 -0400 Received: from mga05.intel.com ([192.55.52.43]:10174 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751404AbcJBKYw (ORCPT ); Sun, 2 Oct 2016 06:24:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,284,1473145200"; d="scan'208";a="15873151" Date: Sun, 2 Oct 2016 13:24:55 +0300 From: Jarkko Sakkinen To: Tomas Winkler Cc: tpmdd-devel@lists.sourceforge.net, Jason Gunthorpe , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tpm: don't destroy chip device prematurely Message-ID: <20161002102455.GA27464@intel.com> References: <1475393971-12715-1-git-send-email-tomas.winkler@intel.com> <20161002101755.GA25844@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161002101755.GA25844@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 772 Lines: 19 On Sun, Oct 02, 2016 at 01:17:55PM +0300, Jarkko Sakkinen wrote: > On Sun, Oct 02, 2016 at 10:39:31AM +0300, Tomas Winkler wrote: > > In tpm_del_char_device device_del is called > > prior to tpm2_shutdown where it is still used. > > > > Fortunately, so far chip->dev was used only for printouts > > int tpm2_shutdown flow, hence system didn't crash. But with > > the introduction of runtime power management it will result in > > shutting down the parent device while it still in use. > > > > Fixes: 20e0152393b41 ("tpm: fix crash in tpm_tis deinitialization") > > Signed-off-by: Tomas Winkler > > Tested-by: Jarkko Sakkinen > Reviewed-by: Jarkko Sakkinen Applied. /Jarkko