Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751939AbcJBPh7 (ORCPT ); Sun, 2 Oct 2016 11:37:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60178 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750856AbcJBPhw (ORCPT ); Sun, 2 Oct 2016 11:37:52 -0400 Date: Sun, 2 Oct 2016 17:37:51 +0200 From: Greg KH To: Shyam Saini Cc: labbott@redhat.com, sumit.semwal@linaro.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, arve@android.com Subject: Re: [PATCH 1/1] Staging: android: ion: Remove explicit NULL comparison using Coccinelle Message-ID: <20161002153751.GA20900@kroah.com> References: <1475076531-4863-1-git-send-email-mayhs11saini@gmail.com> <20161002145849.GA31940@kroah.com> <1475421689.2294.4.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1475421689.2294.4.camel@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 950 Lines: 28 On Sun, Oct 02, 2016 at 08:51:29PM +0530, Shyam Saini wrote: > On Sun, 2016-10-02 at 16:58 +0200, Greg KH wrote: > > On Wed, Sep 28, 2016 at 08:58:51PM +0530, shyam saini wrote: > > > > > > Remove the explicit NULL comparison and rewrite in a compact form. > > > > > > Signed-off-by: shyam saini > > > --- > > > ?drivers/staging/android/ion/ion_of.c | 2 +- > > > ?1 file changed, 1 insertion(+), 1 deletion(-) > > > > Does not apply to my tree :( > > > Do I need to rebase it? Because I have already included all the > maintainers in the patch which I got from ?scripts/get_maintainer.pl. If you want it applied, yes, you need to rebase it. Listing the maintainers doesn't help the patch to somehow magically be able to be applied to the tree :) Please work against my staging-testing branch of the staging.git tree, as it has a lot of patches I just accepted in it that are not yet in linux-next. thanks, greg k-h