Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S262569AbTCZVNA>; Wed, 26 Mar 2003 16:13:00 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S262570AbTCZVNA>; Wed, 26 Mar 2003 16:13:00 -0500
Received: from 12-231-249-244.client.attbi.com ([12.231.249.244]:11014 "HELO
	kroah.com") by vger.kernel.org with SMTP id <S262569AbTCZVM6>;
	Wed, 26 Mar 2003 16:12:58 -0500
Date: Wed, 26 Mar 2003 13:23:18 -0800
From: Greg KH <greg@kroah.com>
To: Christoph Hellwig <hch@infradead.org>, Jan Dittmer <j.dittmer@portrix.net>,
       azarah@gentoo.org, KML <linux-kernel@vger.kernel.org>,
       Dominik Brodowski <linux@brodo.de>, sensors@stimpy.netroedge.com
Subject: Re: w83781d i2c driver updated for 2.5.66 (without sysfs support)
Message-ID: <20030326212318.GA26886@kroah.com>
References: <1048582394.4774.7.camel@workshop.saharact.lan> <20030325175603.GG15823@kroah.com> <1048705473.7569.10.camel@nosferatu.lan> <3E82024A.4000809@portrix.net> <20030326202622.GJ24689@kroah.com> <20030326204343.A22053@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030326204343.A22053@infradead.org>
User-Agent: Mutt/1.4i
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1181
Lines: 26

On Wed, Mar 26, 2003 at 08:43:43PM +0000, Christoph Hellwig wrote:
> On Wed, Mar 26, 2003 at 12:26:23PM -0800, Greg KH wrote:
> > We should really split these multivalue files up into individual files,
> > as sysfs is for single value files.  Makes parsing easier too.
> > 
> > Here's a patch for the lm75.c driver that does this.  As we are going to
> > need a "generic" read and write for the "real" values that the i2c
> > drivers use, I added these files to the i2c-proc.c file.
> 
> i2c-proc.c is the wrong place.  Please add a i2c-sensor.c file with
> helper code for hardware sensors driver (i2c_detect should move over to
> there from i2c-proc.c aswell)

Oh, I agree.  I just threw it there as I was matching up with other
functions already in that file.  Eventually i2c-proc.c should be
deleted, as all of the proc stuff will be gone.  I like the idea of
i2c-sensor.c for the remaining i2c_detect() function.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/