Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751969AbcJBSNK (ORCPT ); Sun, 2 Oct 2016 14:13:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37146 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751006AbcJBSNB (ORCPT ); Sun, 2 Oct 2016 14:13:01 -0400 Date: Sun, 2 Oct 2016 20:13:01 +0200 From: Greg KH To: Edward Lipinsky Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, sudip@vectorindia.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: sm750fb: Fix printk() style warning Message-ID: <20161002181301.GA22637@kroah.com> References: <20161002180505.GA19813@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161002180505.GA19813@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 834 Lines: 26 On Sun, Oct 02, 2016 at 11:05:05AM -0700, Edward Lipinsky wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: printk() should include KERN_ facility level > > Signed-off-by: Edward Lipinsky > --- > drivers/staging/sm750fb/ddk750_help.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c > index 9637dd3..e72a29c 100644 > --- a/drivers/staging/sm750fb/ddk750_help.c > +++ b/drivers/staging/sm750fb/ddk750_help.c > @@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId) > devId750 = devId; > revId750 = revId; > if (revId == 0xfe) > - printk("found sm750le\n"); > + pr_info("found sm750le\n"); Why can't you use dev_info() here? thanks, greg k-h