Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751764AbcJBV2O (ORCPT <rfc822;w@1wt.eu>);
        Sun, 2 Oct 2016 17:28:14 -0400
Received: from quartz.orcorp.ca ([184.70.90.242]:48417 "EHLO quartz.orcorp.ca"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750822AbcJBV2H (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 2 Oct 2016 17:28:07 -0400
Date: Sun, 2 Oct 2016 15:28:01 -0600
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, Nayna Jain <nayna@linux.vnet.ibm.com>,
        Marcel Selhorst <tpmdd@selhorst.net>,
        "moderated list:TPM DEVICE DRIVER" 
        <tpmdd-devel@lists.sourceforge.net>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND 2/3] tpm: replace dynamically allocated bios_dir
 with a static array
Message-ID: <20161002212801.GC25872@obsidianresearch.com>
References: <1475349926-476-1-git-send-email-jarkko.sakkinen@linux.intel.com>
 <1475349926-476-3-git-send-email-jarkko.sakkinen@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1475349926-476-3-git-send-email-jarkko.sakkinen@linux.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 209
Lines: 8

On Sat, Oct 01, 2016 at 10:25:25PM +0300, Jarkko Sakkinen wrote:

> +	for (i = (TPM_NUM_EVENT_LOG_FILES - 1); i >= 0; i--) {
> +		if (chip->bios_dir[i])

The entries can't actually be null here, right?

Jason