Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752329AbcJCFq1 (ORCPT ); Mon, 3 Oct 2016 01:46:27 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:34183 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751388AbcJCFqU (ORCPT ); Mon, 3 Oct 2016 01:46:20 -0400 MIME-Version: 1.0 In-Reply-To: <1474893160-12321-4-git-send-email-ard.biesheuvel@linaro.org> References: <1474893160-12321-1-git-send-email-ard.biesheuvel@linaro.org> <1474893160-12321-4-git-send-email-ard.biesheuvel@linaro.org> From: Alexandre Courbot Date: Mon, 3 Oct 2016 14:45:59 +0900 Message-ID: Subject: Re: [Nouveau] [PATCH v4 3/3] drm/nouveau/fb/nv50: defer DMA mapping of scratch page to init() hook To: Ard Biesheuvel Cc: Linux Kernel Mailing List , Ben Skeggs , David Airlie , "dri-devel@lists.freedesktop.org" , "nouveau@lists.freedesktop.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 631 Lines: 15 On Mon, Sep 26, 2016 at 9:32 PM, Ard Biesheuvel wrote: > The 100c08 scratch page is mapped using dma_map_page() before the TTM > layer has had a chance to set the DMA mask. This means we are still > running with the default of 32 when this code executes, and this causes > problems for platforms with no memory below 4 GB (such as AMD Seattle) > > So move the dma_map_page() to the .init hook, which executes after the > DMA mask has been set. The comments I did on gf100 also apply here. The only difference is that you will have to create the oneinit hook which does not exist in this file. Thanks!