Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752772AbcJCMmk (ORCPT ); Mon, 3 Oct 2016 08:42:40 -0400 Received: from mga02.intel.com ([134.134.136.20]:41490 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752200AbcJCMmb (ORCPT ); Mon, 3 Oct 2016 08:42:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,289,1473145200"; d="scan'208";a="1065452821" Date: Mon, 3 Oct 2016 15:42:25 +0300 From: Jarkko Sakkinen To: "Winkler, Tomas" Cc: Jason Gunthorpe , "tpmdd-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] tpm: don't destroy chip device prematurely Message-ID: <20161003124225.GD9990@intel.com> References: <1475393971-12715-1-git-send-email-tomas.winkler@intel.com> <20161002101755.GA25844@intel.com> <20161002102455.GA27464@intel.com> <20161002212126.GA25872@obsidianresearch.com> <5B8DA87D05A7694D9FA63FD143655C1B542F466B@hasmsx108.ger.corp.intel.com> <5B8DA87D05A7694D9FA63FD143655C1B542F46C1@hasmsx108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B542F46C1@hasmsx108.ger.corp.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1725 Lines: 37 On Mon, Oct 03, 2016 at 07:38:44AM +0000, Winkler, Tomas wrote: > > > > > On Sun, Oct 02, 2016 at 01:24:55PM +0300, Jarkko Sakkinen wrote: > > > > On Sun, Oct 02, 2016 at 01:17:55PM +0300, Jarkko Sakkinen wrote: > > > > > On Sun, Oct 02, 2016 at 10:39:31AM +0300, Tomas Winkler wrote: > > > > > > In tpm_del_char_device device_del is called prior to > > > > > > tpm2_shutdown where it is still used. > > > > > > > > > > > > Fortunately, so far chip->dev was used only for printouts int > > > > > > tpm2_shutdown flow, hence system didn't crash. But with the > > > > > > introduction of runtime power management it will result in > > > > > > shutting down the parent device while it still in use. > > > > > > > > > > > > Fixes: 20e0152393b41 ("tpm: fix crash in tpm_tis > > > > > > deinitialization") > > > > > > Signed-off-by: Tomas Winkler > > > > > > > > > > Tested-by: Jarkko Sakkinen > > > > > Reviewed-by: Jarkko Sakkinen > > > > > > > > Applied. > > > > > > This patch is wrong, I though the comments were clear. All entry > > > points to find the device must be deleted before we commit to shutting > > down the device. > > > > > > You need to figure out some other way to solve your problem. > > > > Please be more specific regarding flows you think will be wrong with this > > patch, you must agree that the current code is broken even w/o runtime pm. > > I've looked to the registration code and it indeed has few more issues > Maybe TPM_CHIP_FLAG_REGISTERED can be used for sealing the access to the device during deregistration, current usage is void. Good catch BTW. This flag has gone quite obsolote. /Jarkko