Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753176AbcJCPrK (ORCPT ); Mon, 3 Oct 2016 11:47:10 -0400 Received: from mail-it0-f48.google.com ([209.85.214.48]:37078 "EHLO mail-it0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752763AbcJCPqw (ORCPT ); Mon, 3 Oct 2016 11:46:52 -0400 MIME-Version: 1.0 In-Reply-To: <12dad169-de04-ce7d-0422-94c57074c839@ti.com> References: <1475243564-15765-1-git-send-email-bgolaszewski@baylibre.com> <12dad169-de04-ce7d-0422-94c57074c839@ti.com> From: Bartosz Golaszewski Date: Mon, 3 Oct 2016 17:46:51 +0200 Message-ID: Subject: Re: [PATCH v2] drm: tilcdc: add a da850-specific compatible string To: Sekhar Nori Cc: Jyri Sarha , Tomi Valkeinen , David Airlie , Kevin Hilman , Michael Turquette , LKML , arm-soc , linux-drm Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 955 Lines: 26 2016-10-01 11:30 GMT+02:00 Sekhar Nori : > On Friday 30 September 2016 07:22 PM, Bartosz Golaszewski wrote: >> Due to some potential tweaks for the da850 LCDC (for example: the >> required memory bandwith settings) we need a separate compatible >> for the IP present on the da850 boards. >> > > This documentation does not help much :( It should be on the lines of: > > compatible: value should be "ti,am33xx-tilcdc" for AM335x based boards > value should be "ti,da850-tilcdc" for DA850/AM18x/OMAP-L138 > based boards > > There are many existing examples of the way compatible strings are > documented. You can take a look at them too. Also, since you are > introducing a new device-tree compatible, please keep the devicetree > list and maintainers in CC too. I don't think it shows up in > get_maintainer.pl, so you will have to remember to do it. > Hi Sekhar, sorry for that, hope v3 is good. Thanks, Bartosz