Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753107AbcJCSMP (ORCPT ); Mon, 3 Oct 2016 14:12:15 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34570 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752966AbcJCSMN (ORCPT ); Mon, 3 Oct 2016 14:12:13 -0400 Subject: Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in prism2sta.c To: Joe Perches , gregkh@linuxfoundation.org References: <1475510655-12729-1-git-send-email-sergio.paracuellos@gmail.com> <1475510655-12729-15-git-send-email-sergio.paracuellos@gmail.com> <1475511366.24781.1.camel@perches.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Sergio Paracuellos Message-ID: <57F29F79.5060301@gmail.com> Date: Mon, 3 Oct 2016 20:12:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1475511366.24781.1.camel@perches.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 975 Lines: 29 El 2016年10月03日 a las 18:16, Joe Perches escribió: > On Mon, 2016-10-03 at 18:04 +0200, Sergio Paracuellos wrote: >> This patch fix the following checkpatch.pl warnings in prism2sta.c: >> WARNING: line over 80 characters > [] >> diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c > [] >> @@ -1099,7 +1101,8 @@ static void prism2sta_inf_hostscanresults(struct wlandevice *wlandev, >> >> kfree(hw->scanresults); >> >> - hw->scanresults = kmemdup(inf, sizeof(struct hfa384x_InfFrame), GFP_ATOMIC); >> + hw->scanresults = kmemdup(inf, >> + sizeof(struct hfa384x_InfFrame), GFP_ATOMIC); > > Perhaps better as > > hw->scanresults = kmemdup(inf, sizeof(*inf), GFP_ATOMIC); > I agree. But because all the code is full of sizeof(struct xxx) I though it would be better to follow the actual style and not change only one... I don't have any problem in fix this patch and resend it. What should I do? Cheers, Sergio Paracuellos