DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 1B7106141A
Date: Mon, 3 Oct 2016 14:03:50 -0700
From: Stephen Boyd <sboyd@codeaurora.org>
To: kgunda@codeaurora.org
Cc: Mark Brown <broonie@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        linux-kernel@vger.kernel.org, aghayal@qti.qualcomm.com,
        adharmap@codeaurora.org
Subject: Re: [PATCH] spmi: regmap: enable userspace writes
Message-ID: <20161003210350.GB8871@codeaurora.org>
References: <1475148990-11272-1-git-send-email-kgunda@codeaurora.org>
 <20160929180016.6tk24tltbzplzlpp@sirena.org.uk>
 <128966d05cff74d2da786abfb0404071@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <128966d05cff74d2da786abfb0404071@codeaurora.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 736
Lines: 20

On 09/30, kgunda@codeaurora.org wrote:
> On 2016-09-29 23:30, Mark Brown wrote:
> >On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote:
> >
> >>-#undef REGMAP_ALLOW_WRITE_DEBUGFS
> >>+#define REGMAP_ALLOW_WRITE_DEBUGFS
> >
> >This is completely inappropriate for upstream, if you need to do
> >debugging on your platform you can enable this locally but enabling
> >random writes from userspace to any regmap device is really not a good
> >idea for system stablity or robustness.
> 
> Sure. I will remove this change and send the next version only to update
> the spmi device name.

Why? The device name looks fine.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project