Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753022AbcJDASk (ORCPT ); Mon, 3 Oct 2016 20:18:40 -0400 Received: from ozlabs.org ([103.22.144.67]:53633 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751769AbcJDASj (ORCPT ); Mon, 3 Oct 2016 20:18:39 -0400 From: Michael Ellerman To: Andrew Morton , Kees Cook , Denys Vlasenko Cc: "linuxppc-dev\@lists.ozlabs.org" , Jason Gunthorpe , Benjamin Herrenschmidt , Paul Mackerras , "Aneesh Kumar K.V" , Oleg Nesterov , Florian Weimer , Linux-MM , LKML Subject: Re: [PATCH v6] powerpc: Do not make the entire heap executable In-Reply-To: References: <20161003161322.3835-1-dvlasenk@redhat.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Tue, 04 Oct 2016 11:18:37 +1100 Message-ID: <877f9p55lu.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1307 Lines: 33 Kees Cook writes: > On Mon, Oct 3, 2016 at 9:13 AM, Denys Vlasenko wrote: >> On 32-bit powerpc the ELF PLT sections of binaries (built with --bss-plt, >> or with a toolchain which defaults to it) look like this: ... >> >> Signed-off-by: Jason Gunthorpe >> Signed-off-by: Denys Vlasenko >> Acked-by: Kees Cook >> Acked-by: Michael Ellerman >> CC: Benjamin Herrenschmidt >> CC: Paul Mackerras >> CC: "Aneesh Kumar K.V" >> CC: Kees Cook >> CC: Oleg Nesterov >> CC: Michael Ellerman >> CC: Florian Weimer >> CC: linux-mm@kvack.org >> CC: linuxppc-dev@lists.ozlabs.org >> CC: linux-kernel@vger.kernel.org >> --- >> Changes since v5: >> * made do_brk_flags() error out if any bits other than VM_EXEC are set. >> (Kees Cook: "With this, I'd be happy to Ack.") >> See https://patchwork.ozlabs.org/patch/661595/ > > Excellent, thanks for the v6! Should this go via the ppc tree or the -mm tree? -mm would be best, given the diffstat I think it's less likely to conflict if it goes via -mm. cheers