Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753525AbcJDBwK (ORCPT ); Mon, 3 Oct 2016 21:52:10 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:52750 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753399AbcJDBwH (ORCPT ); Mon, 3 Oct 2016 21:52:07 -0400 Date: Mon, 03 Oct 2016 21:52:00 -0400 (EDT) Message-Id: <20161003.215200.2029190598743365433.davem@davemloft.net> To: baoyou.xie@linaro.org Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, yankejian@huawei.com, huangdaode@hisilicon.com, lisheng011@huawei.com, xieqianqian@huawei.com, fabf@skynet.be, lipeng321@huawei.com, colin.king@canonical.com, simon.horman@netronome.com, arnd@arndb.de, andrew@lunn.ch, ivecera@redhat.com, chenny.xu@huawei.com, xypron.glpk@gmx.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn, han.fei@zte.com.cn, tang.qiang007@zte.com.cn Subject: Re: [PATCH v3] net: hns: mark symbols static where possible From: David Miller In-Reply-To: <1475309726-21334-1-git-send-email-baoyou.xie@linaro.org> References: <1475309726-21334-1-git-send-email-baoyou.xie@linaro.org> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 03 Oct 2016 18:52:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 418 Lines: 12 From: Baoyou Xie Date: Sat, 1 Oct 2016 16:15:26 +0800 > We get a few warnings when building kernel with W=1: ... > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > So this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie Still doesn't apply to net-next.