Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752336AbcJDEqD (ORCPT <rfc822;w@1wt.eu>);
        Tue, 4 Oct 2016 00:46:03 -0400
Received: from mail-wm0-f68.google.com ([74.125.82.68]:33880 "EHLO
        mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751032AbcJDEqB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 4 Oct 2016 00:46:01 -0400
Subject: Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in
 prism2sta.c
To: Joe Perches <joe@perches.com>, gregkh@linuxfoundation.org
References: <1475510655-12729-1-git-send-email-sergio.paracuellos@gmail.com>
 <1475510655-12729-15-git-send-email-sergio.paracuellos@gmail.com>
 <1475511366.24781.1.camel@perches.com> <57F29F79.5060301@gmail.com>
 <1475518703.24781.4.camel@perches.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Message-ID: <57F33406.8030904@gmail.com>
Date: Tue, 4 Oct 2016 06:45:58 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <1475518703.24781.4.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 761
Lines: 19

El 2016年10月03日 a las 20:18, Joe Perches escribió:
> On Mon, 2016-10-03 at 20:12 +0200, Sergio Paracuellos wrote:
>> El 2016年10月03日 a las 18:16, Joe Perches escribió:
>>> Perhaps better as	hw->scanresults = kmemdup(inf, sizeof(*inf), GFP_ATOMIC);
>> I agree. But because all the code is full of sizeof(struct xxx) I though
>> it would be bettter to follow the actual style and not change only one...
>> I don't have any problem in fix this patch and resend it. What should I do?
>
> I suggest not fixing this patch.
>
> Maybe just send another patch changing all the applicable
> sizeof(struct <foo>) uses to sizeof(*var) with the appropriate
> line wrapping.
>

Ok, I think that it would be better too. Let's do that.

Thanks,
	Sergio Paracuellos