Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752980AbcJDHJJ (ORCPT ); Tue, 4 Oct 2016 03:09:09 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33117 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752253AbcJDHJH (ORCPT ); Tue, 4 Oct 2016 03:09:07 -0400 Subject: Re: [PATCH -resend 4/6] mdacon: enable COMPILE_TEST build To: Geert Uytterhoeven References: <20161003090736.19926-1-jslaby@suse.cz> <20161003090736.19926-4-jslaby@suse.cz> Cc: Andrew Morton , "linux-kernel@vger.kernel.org" , Tomi Valkeinen , Linux Fbdev development list From: Jiri Slaby Message-ID: <6c80ac98-8034-0007-0e98-755609b78fcd@suse.cz> Date: Tue, 4 Oct 2016 09:09:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 561 Lines: 21 On 10/03/2016, 11:35 AM, Geert Uytterhoeven wrote: >> - depends on !M68K && !PARISC && ISA >> + depends on !M68K && !PARISC && (ISA || COMPILE_TEST) > > My first thought was > > depends on (!M68K && !PARISC && ISA) || COMPILE_TEST > > but arch/m68k/include/asm/vga.h doesn't define VGA_MAP_MEM(). > Adding #include at the end of arch/m68k/include/asm/vga.h > fixes that. > > Do we want that? The driver is not used much nowadays, so compile-testing on other architectures is not worth it IMHO. thanks, -- js suse labs