Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753532AbcJDLWK (ORCPT ); Tue, 4 Oct 2016 07:22:10 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:35105 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900AbcJDLWJ (ORCPT ); Tue, 4 Oct 2016 07:22:09 -0400 Date: Tue, 4 Oct 2016 14:26:14 +0300 From: Antony Pavlov To: Neil Armstrong Cc: Yegor Yefremov , Alban , ralf@linux-mips.org, linux-mips , kernel list Subject: Re: [PATCH] MIPS: ath79: Add initial support for the HAPROXY Aloha Pocket board Message-Id: <20161004142614.4983d133078b4908e43efa3a@gmail.com> In-Reply-To: <154dc5c8-0d40-9cd7-5997-0ede70605510@baylibre.com> References: <1475508931-16800-1-git-send-email-narmstrong@baylibre.com> <20161004110940.57d112df@tock> <3b41a114-7ec7-cd50-6967-9a1be96e2c2f@baylibre.com> <154dc5c8-0d40-9cd7-5997-0ede70605510@baylibre.com> X-Mailer: Sylpheed 3.5.0beta3 (GTK+ 2.24.25; i586-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u94BMFCJ007292 Content-Length: 2026 Lines: 56 On Tue, 4 Oct 2016 12:11:11 +0200 Neil Armstrong wrote: > On 10/04/2016 12:09 PM, Yegor Yefremov wrote: > > Hi Neil, > > > > On Tue, Oct 4, 2016 at 11:40 AM, Neil Armstrong wrote: > >> On 10/04/2016 11:09 AM, Alban wrote: > >>> On Mon, 3 Oct 2016 17:35:31 +0200 > >>> Neil Armstrong wrote: > >>> > >>>> The HAPROXY Aloha pocket board is a Load Balancer demo board based on the > >>>> Atheros AR9331 SoC with 64Mbytes DDR and 16Mbytes on-board SPI Flash. > >>>> > >>>> Signed-off-by: Neil Armstrong > >>> > >>> Please use device tree instead of adding another board file. > >>> > >>> Alban > >>> > >> > >> Hi Alban, > >> > >> I'm quite surprised since it seems no device tree support is available for ath79, > >> I would really like to have device tree for this board, but this is only a copy/paste of > >> the mach-ap121 with button/leds gpio differences. > >> > >> Could it be possible to merge it ? I would be happy to support this board once device tree > >> support is landed on the mips tree ! > > > > Take a look at these DTS files from the current Linux tree: > > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/mips/boot/dts/qca/ar9331_dpt_module.dts > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts > > > > etc. > > > > Regards, > > Yegor > > > > My bad, the qca naming is really disturbing. > > I will push a dts instead. Please note that currently some led's names in device tree files are wrong (e.g. dragino2 device tree https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/mips/boot/dts/qca/ar9331_dragino_ms14.dts . My bad! I have just copied led's names from OpenWRT platform files). Please see the 'LED Device Naming' chapter for correct led naming scheme: http://lxr.free-electrons.com/source/Documentation/leds/leds-class.txt#L41 --? Best regards, ? Antony Pavlov