Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753298AbcJDLZ1 (ORCPT ); Tue, 4 Oct 2016 07:25:27 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:34035 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900AbcJDLZZ (ORCPT ); Tue, 4 Oct 2016 07:25:25 -0400 MIME-Version: 1.0 X-Originating-IP: [2a02:168:56b5:0:ac27:b86c:7764:9429] In-Reply-To: <48ef75ce-061f-d9b0-d5fb-4503af2e5f71@nvidia.com> References: <1473415010-1389-1-git-send-email-tomeu.vizoso@collabora.com> <1473415010-1389-3-git-send-email-tomeu.vizoso@collabora.com> <48ef75ce-061f-d9b0-d5fb-4503af2e5f71@nvidia.com> From: Daniel Vetter Date: Tue, 4 Oct 2016 13:25:23 +0200 X-Google-Sender-Auth: P1Ep1hznIlWQEA6RH-fKKtgsJgQ Message-ID: Subject: Re: [PATCH v8 2/4] drm: Add API for capturing frame CRCs To: Jon Hunter Cc: Tomeu Vizoso , Linux Kernel Mailing List , linux-doc@vger.kernel.org, Jonathan Corbet , Emil Velikov , dri-devel , Daniel Vetter Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 656 Lines: 15 On Tue, Oct 4, 2016 at 12:10 PM, Jon Hunter wrote: > Looks like crtc is a errno in the above case. I see this function is > called by looping through all the crtc and we never check to see if > they are valid. Should we? Tegra is still using the load/unload hooks. That didn't mesh well with Tomeu's patches (and Tomeu's patches have been thrown out meanwhile because of that). Still would be neat if tegra could be demidlayered and loose it's load/unload hooks. See the kerneldoc in drm_drv.c (especially the DOC: section). -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch