Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753929AbcJDMPb convert rfc822-to-8bit (ORCPT ); Tue, 4 Oct 2016 08:15:31 -0400 Received: from down.free-electrons.com ([37.187.137.238]:57580 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751020AbcJDMP3 (ORCPT ); Tue, 4 Oct 2016 08:15:29 -0400 Date: Tue, 4 Oct 2016 14:15:16 +0200 From: Thomas Petazzoni To: =?UTF-8?B?TXlsw6huZQ==?= Josserand Cc: vinod.koul@intel.com, maxime.ripard@free-electrons.com, wens@csie.org, mturquette@baylibre.com, sboyd@codeaurora.org, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, lee.jones@linaro.org, mark.rutland@arm.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, alexandre.belloni@free-electrons.com Subject: Re: [PATCH 03/14] ASoC: sun4i-i2s: Add apb reset Message-ID: <20161004141516.53c6fa8c@free-electrons.com> In-Reply-To: <2c5abe6578c8e4e841cb59357d88ce397551a593.1475571575.git.mylene.josserand@free-electrons.com> References: <2c5abe6578c8e4e841cb59357d88ce397551a593.1475571575.git.mylene.josserand@free-electrons.com> Organization: Free Electrons X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1311 Lines: 51 Hello, On Tue, 4 Oct 2016 11:46:16 +0200, Mylène Josserand wrote: > #include > #include > @@ -589,6 +590,7 @@ static int sun4i_i2s_probe(struct platform_device *pdev) > { > struct sun4i_i2s *i2s; > struct resource *res; > + struct reset_control *reset_apb; > void __iomem *regs; > int irq, ret; > > @@ -626,7 +628,19 @@ static int sun4i_i2s_probe(struct platform_device *pdev) > dev_err(&pdev->dev, "Can't get our mod clock\n"); > return PTR_ERR(i2s->mod_clk); > } > - > + > + reset_apb = devm_reset_control_get(&pdev->dev, "apb_reset"); I believe this is a change in the Device Tree binding, since you're adding support for a new resource. Perhaps the Device Tree binding documentation should be updated accordingly? > + if (IS_ERR(reset_apb)) { > + dev_err(&pdev->dev, "Can't get apb reset\n"); > + return PTR_ERR(i2s->mod_clk); This should be: return PTR_ERR(reset_apb); > + } > + > + ret = reset_control_deassert(reset_apb); > + if (ret < 0) { > + dev_err(&pdev->dev, "Can't deassert apb reset (%d)\n", ret); > + return ret; > + } Do you need to re-assert the reset line in the ->remove() hook? Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com