Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753614AbcJDMWa (ORCPT ); Tue, 4 Oct 2016 08:22:30 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:34426 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751549AbcJDMW1 (ORCPT ); Tue, 4 Oct 2016 08:22:27 -0400 MIME-Version: 1.0 In-Reply-To: <2c5abe6578c8e4e841cb59357d88ce397551a593.1475571575.git.mylene.josserand@free-electrons.com> References: <2c5abe6578c8e4e841cb59357d88ce397551a593.1475571575.git.mylene.josserand@free-electrons.com> From: Code Kipper Date: Tue, 4 Oct 2016 14:22:26 +0200 Message-ID: Subject: Re: [PATCH 03/14] ASoC: sun4i-i2s: Add apb reset To: =?UTF-8?Q?Myl=C3=A8ne_Josserand?= Cc: vinod.koul@intel.com, Maxime Ripard , Chen-Yu Tsai , mturquette@baylibre.com, sboyd@codeaurora.org, Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Lee Jones , mark.rutland@arm.com, Rob Herring , thomas.petazzoni@free-electrons.com, devicetree , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-sunxi , alexandre.belloni@free-electrons.com, dmaengine@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u94CMjYK007518 Content-Length: 2010 Lines: 60 On 4 October 2016 at 11:46, Mylène Josserand wrote: > Add APB deassert function for sun4i-i2s driver. > > Signed-off-by: Mylène Josserand > --- > sound/soc/sunxi/sun4i-i2s.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c > index 687a8f8..f3f7026 100644 > --- a/sound/soc/sunxi/sun4i-i2s.c > +++ b/sound/soc/sunxi/sun4i-i2s.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > > #include > #include > @@ -589,6 +590,7 @@ static int sun4i_i2s_probe(struct platform_device *pdev) > { > struct sun4i_i2s *i2s; > struct resource *res; > + struct reset_control *reset_apb; > void __iomem *regs; > int irq, ret; > > @@ -626,7 +628,19 @@ static int sun4i_i2s_probe(struct platform_device *pdev) > dev_err(&pdev->dev, "Can't get our mod clock\n"); > return PTR_ERR(i2s->mod_clk); > } > - > + > + reset_apb = devm_reset_control_get(&pdev->dev, "apb_reset"); > + if (IS_ERR(reset_apb)) { > + dev_err(&pdev->dev, "Can't get apb reset\n"); > + return PTR_ERR(i2s->mod_clk); > + } > + > + ret = reset_control_deassert(reset_apb); > + if (ret < 0) { > + dev_err(&pdev->dev, "Can't deassert apb reset (%d)\n", ret); > + return ret; > + } > + Is this functionality only required for A31 and onwards?, CK > i2s->playback_dma_data.addr = res->start + SUN4I_I2S_FIFO_TX_REG; > i2s->playback_dma_data.maxburst = 4; > > -- > 2.9.3 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel