Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753973AbcJDMXO (ORCPT ); Tue, 4 Oct 2016 08:23:14 -0400 Received: from mailout1.hostsharing.net ([83.223.95.204]:48299 "EHLO mailout1.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752738AbcJDMXM (ORCPT ); Tue, 4 Oct 2016 08:23:12 -0400 Date: Tue, 4 Oct 2016 14:23:13 +0200 From: Lukas Wunner To: Daniel Vetter Cc: Jon Hunter , Tomeu Vizoso , Jonathan Corbet , linux-doc@vger.kernel.org, Emil Velikov , Linux Kernel Mailing List , dri-devel , Daniel Vetter Subject: Re: [PATCH v8 2/4] drm: Add API for capturing frame CRCs Message-ID: <20161004122313.GA4832@wunner.de> References: <1473415010-1389-1-git-send-email-tomeu.vizoso@collabora.com> <1473415010-1389-3-git-send-email-tomeu.vizoso@collabora.com> <48ef75ce-061f-d9b0-d5fb-4503af2e5f71@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 612 Lines: 18 On Tue, Oct 04, 2016 at 01:25:23PM +0200, Daniel Vetter wrote: > On Tue, Oct 4, 2016 at 12:10 PM, Jon Hunter wrote: > > Looks like crtc is a errno in the above case. I see this function is > > called by looping through all the crtc and we never check to see if > > they are valid. Should we? nouveau is exploding as well on driver load! > Tegra is still using the load/unload hooks. That didn't mesh well with > Tomeu's patches (and Tomeu's patches have been thrown out meanwhile > because of that). They're still on drm-intel-nightly, please revert if they're broken. Thanks, Lukas