Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753742AbcJDMio (ORCPT <rfc822;w@1wt.eu>);
        Tue, 4 Oct 2016 08:38:44 -0400
Received: from hqemgate14.nvidia.com ([216.228.121.143]:7663 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751393AbcJDMim (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 4 Oct 2016 08:38:42 -0400
X-PGP-Universal: processed;
        by hqnvupgp08.nvidia.com on Tue, 04 Oct 2016 05:32:20 -0700
Subject: Re: [PATCH v8 2/4] drm: Add API for capturing frame CRCs
To: Daniel Vetter <daniel@ffwll.ch>
References: <1473415010-1389-1-git-send-email-tomeu.vizoso@collabora.com>
 <1473415010-1389-3-git-send-email-tomeu.vizoso@collabora.com>
 <48ef75ce-061f-d9b0-d5fb-4503af2e5f71@nvidia.com>
 <CAKMK7uGLhpDt3hWyDG++ey=QepSyi2a8Q4PrZ=8HhETvUbQBCA@mail.gmail.com>
CC: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, Jonathan Corbet <corbet@lwn.net>,
        Emil Velikov <emil.l.velikov@gmail.com>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Thierry Reding <treding@nvidia.com>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        Alexandre Courbot <acourbot@nvidia.com>
From: Jon Hunter <jonathanh@nvidia.com>
Message-ID: <960a3dc0-173d-e0ca-d56d-be468b8b5926@nvidia.com>
Date: Tue, 4 Oct 2016 13:38:35 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <CAKMK7uGLhpDt3hWyDG++ey=QepSyi2a8Q4PrZ=8HhETvUbQBCA@mail.gmail.com>
X-Originating-IP: [10.21.132.115]
X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com
 (10.26.138.13)
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 711
Lines: 20


On 04/10/16 12:25, Daniel Vetter wrote:
> On Tue, Oct 4, 2016 at 12:10 PM, Jon Hunter <jonathanh@nvidia.com> wrote:
>> Looks like crtc is a errno in the above case. I see this function is
>> called by looping through all the crtc and we never check to see if
>> they are valid. Should we?
> 
> Tegra is still using the load/unload hooks. That didn't mesh well with
> Tomeu's patches (and Tomeu's patches have been thrown out meanwhile
> because of that). Still would be neat if tegra could be demidlayered
> and loose it's load/unload hooks. See the kerneldoc in drm_drv.c
> (especially the DOC: section).

Adding Thierry and Alex as this is more their domain and CC'ing linux-tegra.

Cheers
Jon

-- 
nvpublic