Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754144AbcJDNKj (ORCPT ); Tue, 4 Oct 2016 09:10:39 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:38588 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753186AbcJDNKi (ORCPT ); Tue, 4 Oct 2016 09:10:38 -0400 Date: Tue, 4 Oct 2016 15:10:32 +0200 From: Andrew Lunn To: Mugunthan V N Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Mark Rutland , Tony Lindgren , Russell King , Florian Fainelli , David Miller , Sekhar Nori Subject: Re: [PATCH v2 2/4] net: phy: dp83867: add support for MAC impedance configuration Message-ID: <20161004131032.GL11677@lunn.ch> References: <20161004125607.10569-1-mugunthanvnm@ti.com> <20161004125607.10569-3-mugunthanvnm@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161004125607.10569-3-mugunthanvnm@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 301 Lines: 8 > + if (of_property_read_bool(of_node, "ti,max-output-imepdance")) > + dp83867->io_impedance = DP83867_IO_MUX_CFG_IO_IMPEDANCE_MAX; > + else if (of_property_read_bool(of_node, "ti,min-output-imepdance")) Did you really test this? Or did you make the same typos in your device tree file? Andrew