Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753737AbcJDQyQ (ORCPT ); Tue, 4 Oct 2016 12:54:16 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:37589 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752738AbcJDQyP (ORCPT ); Tue, 4 Oct 2016 12:54:15 -0400 MIME-Version: 1.0 In-Reply-To: <877f9p55lu.fsf@concordia.ellerman.id.au> References: <20161003161322.3835-1-dvlasenk@redhat.com> <877f9p55lu.fsf@concordia.ellerman.id.au> From: Kees Cook Date: Tue, 4 Oct 2016 09:54:12 -0700 X-Google-Sender-Auth: icmHE6pnZRE_loGz3VtAfJZ-l6g Message-ID: Subject: Re: [PATCH v6] powerpc: Do not make the entire heap executable To: Michael Ellerman , Andrew Morton Cc: Denys Vlasenko , "linuxppc-dev@lists.ozlabs.org" , Jason Gunthorpe , Benjamin Herrenschmidt , Paul Mackerras , "Aneesh Kumar K.V" , Oleg Nesterov , Florian Weimer , Linux-MM , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1563 Lines: 41 On Mon, Oct 3, 2016 at 5:18 PM, Michael Ellerman wrote: > Kees Cook writes: > >> On Mon, Oct 3, 2016 at 9:13 AM, Denys Vlasenko wrote: >>> On 32-bit powerpc the ELF PLT sections of binaries (built with --bss-plt, >>> or with a toolchain which defaults to it) look like this: > ... >>> >>> Signed-off-by: Jason Gunthorpe >>> Signed-off-by: Denys Vlasenko >>> Acked-by: Kees Cook >>> Acked-by: Michael Ellerman >>> CC: Benjamin Herrenschmidt >>> CC: Paul Mackerras >>> CC: "Aneesh Kumar K.V" >>> CC: Kees Cook >>> CC: Oleg Nesterov >>> CC: Michael Ellerman >>> CC: Florian Weimer >>> CC: linux-mm@kvack.org >>> CC: linuxppc-dev@lists.ozlabs.org >>> CC: linux-kernel@vger.kernel.org >>> --- >>> Changes since v5: >>> * made do_brk_flags() error out if any bits other than VM_EXEC are set. >>> (Kees Cook: "With this, I'd be happy to Ack.") >>> See https://patchwork.ozlabs.org/patch/661595/ >> >> Excellent, thanks for the v6! Should this go via the ppc tree or the -mm tree? > > -mm would be best, given the diffstat I think it's less likely to > conflict if it goes via -mm. Okay, excellent. Andrew, do you have this already in email? I think you weren't on the explicit CC from the v6... -Kees -- Kees Cook Nexus Security