Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754280AbcJDUxg (ORCPT ); Tue, 4 Oct 2016 16:53:36 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:36520 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753096AbcJDUxe (ORCPT ); Tue, 4 Oct 2016 16:53:34 -0400 From: Harman Kalra To: gregkh@linuxfoundation.org, sudipm.mukherjee@gmail.co Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Harman Kalra Subject: [PATCH] staging: i4l: icn: fixed some errors and warnings caught by checkpatch.pl Date: Wed, 5 Oct 2016 02:23:22 +0530 Message-Id: <1475614403-6426-1-git-send-email-harman4linux@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1633 Lines: 51 2 errors "open brace { should be on the previous line" are fixed. Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed Few line more tahn 80 character warnings fixed Signed-off-by: Harman Kalra --- drivers/staging/i4l/icn/icn.c | 3 +-- drivers/staging/i4l/icn/icn.h | 7 ++++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c index 514bfc2..3750ba3 100644 --- a/drivers/staging/i4l/icn/icn.c +++ b/drivers/staging/i4l/icn/icn.c @@ -411,8 +411,7 @@ int action; } icn_stat; /* *INDENT-OFF* */ -static icn_stat icn_stat_table[] = -{ +static icn_stat icn_stat_table[] = { {"BCON_", ISDN_STAT_BCONN, 1}, /* B-Channel connected */ {"BDIS_", ISDN_STAT_BHUP, 2}, /* B-Channel disconnected */ /* diff --git a/drivers/staging/i4l/icn/icn.h b/drivers/staging/i4l/icn/icn.h index f8f2e76..1e5a487 100644 --- a/drivers/staging/i4l/icn/icn.h +++ b/drivers/staging/i4l/icn/icn.h @@ -54,7 +54,8 @@ /* some useful macros for debugging */ #ifdef ICN_DEBUG_PORT -#define OUTB_P(v, p) {printk(KERN_DEBUG "icn: outb_p(0x%02x,0x%03x)\n", v, p); outb_p(v, p);} +#define OUTB_P(v, p) \ + {pr_debug("icn: outb_p(0x%02x,0x%03x)\n", v, p); outb_p(v, p); } #else #define OUTB_P outb #endif @@ -186,8 +187,8 @@ #ifdef __KERNEL__ static icn_card *cards = (icn_card *) 0; -static u_char chan2bank[] = -{0, 4, 8, 12}; /* for icn_map_channel() */ +static u_char chan2bank[] = { + 0, 4, 8, 12}; /* for icn_map_channel() */ static icn_dev dev; -- 1.7.9.5