Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754607AbcJECgd (ORCPT ); Tue, 4 Oct 2016 22:36:33 -0400 Received: from ozlabs.org ([103.22.144.67]:54687 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753807AbcJECga (ORCPT ); Tue, 4 Oct 2016 22:36:30 -0400 X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 735840b44bcc998e2574faf63d1aaaf9b41f2827 In-Reply-To: <1469764534-26948-1-git-send-email-andrew.donnellan@au1.ibm.com> To: Andrew Donnellan , linuxppc-dev@lists.ozlabs.org From: Michael Ellerman Cc: clombard@linux.vnet.ibm.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, fbarrat@linux.vnet.ibm.com, julia.lawall@lip6.fr, imunsie@au1.ibm.com, elfring@users.sourceforge.net Subject: Re: cxl: replace loop with for_each_child_of_node(), remove unneeded of_node_put() Message-Id: <3spfzw6LSRz9t0t@ozlabs.org> Date: Wed, 5 Oct 2016 13:36:28 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 648 Lines: 17 On Fri, 2016-29-07 at 03:55:34 UTC, Andrew Donnellan wrote: > Rewrite the cxl_guest_init_afu() loop in cxl_of_probe() to use > for_each_child_of_node() rather than a hand-coded for loop. > > Remove the useless of_node_put(afu_np) call after the loop, where it's > guaranteed that afu_np == NULL. > > Reported-by: SF Markus Elfring > Reported-by: Julia Lawall > Signed-off-by: Andrew Donnellan > Reviewed-by: Frederic Barrat Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/735840b44bcc998e2574faf63d1aaa cheers