Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754028AbcJEGGZ (ORCPT ); Wed, 5 Oct 2016 02:06:25 -0400 Received: from bear.ext.ti.com ([198.47.19.11]:48572 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751347AbcJEGGX (ORCPT ); Wed, 5 Oct 2016 02:06:23 -0400 Subject: Re: [PATCH V2] OMAPDSS: Kconfig: Add HDMI for OMAP4 and OMAP5 dependencies To: Adam Ford , References: <1475633279-32424-1-git-send-email-aford173@gmail.com> CC: , , , , , From: Tomi Valkeinen Message-ID: Date: Wed, 5 Oct 2016 09:06:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1475633279-32424-1-git-send-email-aford173@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="r66CmpDfuJbhXVTPBBF4N95FpONCfPAxK" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2654 Lines: 66 --r66CmpDfuJbhXVTPBBF4N95FpONCfPAxK Content-Type: multipart/mixed; boundary="735Hjfb363C4sM8uGn6bcRQ38SKFsHNTw"; protected-headers="v1" From: Tomi Valkeinen To: Adam Ford , linux-omap@vger.kernel.org Cc: airlied@linux.ie, airlied@gmail.com, robdclark@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Message-ID: Subject: Re: [PATCH V2] OMAPDSS: Kconfig: Add HDMI for OMAP4 and OMAP5 dependencies References: <1475633279-32424-1-git-send-email-aford173@gmail.com> In-Reply-To: <1475633279-32424-1-git-send-email-aford173@gmail.com> --735Hjfb363C4sM8uGn6bcRQ38SKFsHNTw Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/10/16 05:07, Adam Ford wrote: > Make "HDMI for OMAP4" and "HDMI for OMAP5" depend on ARCH_OMAP4 > and SOC_OMAP5/DRA7XX respectively. >=20 > Signed-off-by: Adam Ford >=20 > Changes in v2: Add dependancy for DRA7XX or OMAP5 You don't say it, but I presume this is just to make those kconfig options disappear automatically if you don't have the specific ARCH_* enabled? I don't like these, as they will just clutter the Kconfig file. Here you only added a few dependencies, but there are a lot more. VENC is only there for some SoC versions, SDI is there only for some, same for RFBI... And with every new SoC type we'd need to update all these. Just disable the HDMI from the Kconfig if you don't want it included. Tomi --735Hjfb363C4sM8uGn6bcRQ38SKFsHNTw-- --r66CmpDfuJbhXVTPBBF4N95FpONCfPAxK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX9JhYAAoJEPo9qoy8lh71orcP/jEjnAeEpUzf5B4m7nsR2Y4s 0N+Mu0Qxskqtwukb9yg93N2g15zS8LQC21OZ67L2NPn2wRD5EslVl34qoFbr4cQB OGxU8yvABitqX2+l9IWG+jaM1W9etHKLxQFNzjzIZWwh9vsf9TkDqyXcuM5HCILP bnHDebAJRxxoVGCORqC+x9CtVDm8iFguLefnxxgKGEwjhgDhGqXCsMAAlTNCumWy 0jUG6qqvU314+QT353uD5Zn5wcGWxZnxZOJMtxHOOGiyhgnl54saCLa2OKA/O6Fs V1sO4lVQclzkI+cabzB1RrC0m7DeAYVKcYE+KpphFGQCkYi6HrhhWiac1WZkpjDN gP/Nh2i5O4TOjcZLQo2CqLSP1BvPdMP2/zmlh7g/GZqOyqnUWMrHKwxXP6JLK3t0 QpyR6N1kgtHg0ixi97roi1ezyijG9VoONtZN+OsGN5YIZxqDFz34nq1Sq05a6p5t U85b+g6HnpE8uAw2wtsGjNK1x9ZFur0MJ5/zGFdHI4sI2QSGdFdcIxkMERaw30K6 pxW9mcQUwjg9tuVIuiVO7V40XYjyDdyNVBy9TC0FIauL51L89hkNncSs8ZYJoZ0W 8QukJCbQ8I4TODqrTvqD9l61R1cB3b3gIdS5TqbdSu3+1Aeoi4z5iEsNNq5yv6FS eI4Y49acTe/KZHYYdl8j =E6L/ -----END PGP SIGNATURE----- --r66CmpDfuJbhXVTPBBF4N95FpONCfPAxK--