Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754525AbcJEGwT (ORCPT ); Wed, 5 Oct 2016 02:52:19 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:47046 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752005AbcJEGwS (ORCPT ); Wed, 5 Oct 2016 02:52:18 -0400 Date: Wed, 5 Oct 2016 08:52:19 +0200 From: Greg KH To: Harman Kalra Cc: sudipm.mukherjee@gmail.co, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: i4l: icn: fixed some errors and warnings caught by checkpatch.pl Message-ID: <20161005065219.GD11013@kroah.com> References: <1475614403-6426-1-git-send-email-harman4linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475614403-6426-1-git-send-email-harman4linux@gmail.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 373 Lines: 11 On Wed, Oct 05, 2016 at 02:23:22AM +0530, Harman Kalra wrote: > 2 errors "open brace { should be on the previous line" are fixed. > Warning "Prefer "pr_debug over printk(KERN_DEBUG... " fixed > Few line more tahn 80 character warnings fixed That's three different things, please make three different patches, don't do multiple things in the same patch. thanks, greg k-h