Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754701AbcJEIWr (ORCPT ); Wed, 5 Oct 2016 04:22:47 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:33423 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754649AbcJEIWp (ORCPT ); Wed, 5 Oct 2016 04:22:45 -0400 Subject: Re: [PATCH 6/6] ARM: da850: adjust memory settings for tilcdc To: Kevin Hilman References: <1475166715-7857-1-git-send-email-bgolaszewski@baylibre.com> <1475166715-7857-7-git-send-email-bgolaszewski@baylibre.com> <4e089d20-d00f-ff54-7c54-85aa061e23c2@ti.com> <91db8934-bfd6-8fc4-74e3-4844ef3bd3e7@ti.com> <948c3f9e-f11b-092c-e002-e2ef4436197f@ti.com> <0125defa-5c34-85d0-f62a-133235c5094c@ti.com> <7hvax8ferr.fsf@baylibre.com> CC: Sekhar Nori , Bartosz Golaszewski , Michael Turquette , Rob Herring , Mark Rutland , Russell King , LKML , arm-soc From: Peter Ujfalusi Message-ID: Date: Wed, 5 Oct 2016 11:22:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <7hvax8ferr.fsf@baylibre.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1411 Lines: 37 On 10/04/16 16:02, Kevin Hilman wrote: > Peter Ujfalusi writes: > >> On 10/01/16 12:24, Sekhar Nori wrote: > > [...] > >>> In any case, to configure the PBBR, you will have to introduce a driver >>> for it in drivers/memory. Then you can set it up per board using a DT >>> parameter. >> >> and we can reuse the introduced bindings for am335x and OMAP1/2 as well. On >> OMAP the legacy DMA API provided a call to raise the priority of the sDMA in >> EMIF :o That needs to be removed and replaced. > > Can you point us to the bindings you're referring to? We don't have one atm. And the DMA priority hack in legacy sDMA code is for OMAP1: omap_set_dma_priority(). Basically it can change the sDMA priority in OCPT1_PRIOR, OCPT2_PRIOR, EMIFF_PRIOR and EMIFS_PRIOR registers. > Also, a new driver in drivers/memory is fine for setting the PBBR, but > what about the SYSCFG0 registers. Are you OK with leaving those in the > init code as proposed in $SUBJECT patch? My problem is - as I described it in reply to Bartosz - is that for example I don't want the LCDC to get high priority on OMAP-L138 EVM from Logic as it does not have LCD/VGA by default. ifdef for LCDC is not good either since my kernel have LCDC compiled in, but it is disabled. The easiest way would be to have pdata quirk to handle the LCDK until we have proper handling of the priority configuration. -- P?ter