Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754853AbcJEMN1 (ORCPT ); Wed, 5 Oct 2016 08:13:27 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:60154 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752666AbcJEMN0 (ORCPT ); Wed, 5 Oct 2016 08:13:26 -0400 Subject: Re: [PATCH 2/9] mtd: spi-nor: add an alternative method to support memory >16MiB To: Cyrille Pitchen , , References: <75db6c008249df8d0646ea5006648e57fea40706.1475597385.git.cyrille.pitchen@atmel.com> CC: , , , From: Vignesh R Message-ID: Date: Wed, 5 Oct 2016 17:42:50 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <75db6c008249df8d0646ea5006648e57fea40706.1475597385.git.cyrille.pitchen@atmel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 746 Lines: 26 Hi, On Tuesday 04 October 2016 10:07 PM, Cyrille Pitchen wrote: [...] > static struct seq_rw_config stfsm_s25fl_write4_configs[] = { > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index 5c87b2d99507..423448c1c7a8 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -75,6 +75,10 @@ struct flash_info { > * bit. Must be used with > * SPI_NOR_HAS_LOCK. > */ > +#define SPI_NOR_4B_OPCODES BIT(10) /* > + * Use dedicated 4byte address op codes > + * to support memory size above 128Mib. > + */ I don't see this flag being added to any flash_info data for any m25p80 compatible flashes? Is that part of a separate series? -- Regards Vignesh